Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395563

Re: [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup
Date 2016-05-06 03:00 +0200
Message-ID <rvChA-2DB-9@gated-at.bofh.it> (permalink)
References <rvAfL-Dg-3@gated-at.bofh.it> <rvAfN-Dg-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 05, 2016 at 06:40:57PM -0400, Vivien Didelot wrote:
> All switch models configure the GLOBAL_CONTROL register with slightly
> differences.

And as far as i know, we have no idea why.
 
> Assume a common setup to enable the PHY Polling Unit if present, discard
> packets with excessive collisions, set the maximum frame size to 1632,
> and mask all interrupt sources.

This is a behaviour change, not just a refactor. It would be good to
say on which families it has been tested, and which have not.

    Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH net-next 00/20] net: dsa: mv88e6xxx: turn into monolithic driver Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 08/20] net: dsa: mv88e6xxx: factorize bridge support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize GLOBAL_CONTROL setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
    Re: [RFC PATCH net-next 13/20] net: dsa: mv88e6xxx: factorize  GLOBAL_CONTROL setup Andrew Lunn <andrew@lunn.ch> - 2016-05-06 03:00 +0200
  [RFC PATCH net-next 05/20] net: dsa: mv88e6xxx: factorize MAC address setting Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 10/20] net: dsa: mv88e6xxx: factorize ATU access Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 07/20] net: dsa: mv88e6xxx: factorize registers access Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 02/20] net: dsa: mv88e6xxx: factorize PHY indirect access Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  [RFC PATCH net-next 03/20] net: dsa: mv88e6xxx: factorize EEPROM access Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  Re: [RFC PATCH net-next 20/20] net: dsa: mv88e6xxx: factorize the  switch driver Andrew Lunn <andrew@lunn.ch> - 2016-05-06 03:20 +0200

csiph-web