Re: [PATCH net] bridge: fix igmp / mld query parsing

From	Linus Lüssing <linus.luessing@c0d3.blue>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] bridge: fix igmp / mld query parsing
Date	2016-05-04 17:00 +0200
Message-ID	<rv6ro-5XA-17@gated-at.bofh.it> (permalink)
References	<ruP7c-6xa-15@gated-at.bofh.it> <ruP7d-6xa-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 03, 2016 at 01:26:23PM -0700, Stephen Hemminger wrote:
> On Tue,  3 May 2016 22:18:54 +0200
> Linus Lüssing <linus.luessing@c0d3.blue> wrote:
> 
> > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> > index 03661d9..7105cdf 100644
> > --- a/net/bridge/br_multicast.c
> > +++ b/net/bridge/br_multicast.c
> > @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br,
> >  	unsigned long max_delay;
> >  	unsigned long now = jiffies;
> >  	__be32 group;
> > +	int offset = skb_transport_offset(skb);
> shouldn't this be unsigned?

Yes, should always be unsigned here.

Ok, I'm changing that (even though skb_transport_offset() is "static
inline int").

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] bridge: fix igmp / mld query parsing Linus Lüssing <linus.luessing@c0d3.blue> - 2016-05-03 22:30 +0200
  Re: [PATCH net] bridge: fix igmp / mld query parsing Stephen Hemminger <stephen@networkplumber.org> - 2016-05-03 22:30 +0200
    Re: [PATCH net] bridge: fix igmp / mld query parsing Linus Lüssing <linus.luessing@c0d3.blue> - 2016-05-04 17:00 +0200

csiph-web