Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1392257
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io |
| Date | 2016-05-02 17:00 +0200 |
| Message-ID | <runui-5gi-1@gated-at.bofh.it> (permalink) |
| References | <rt1vQ-2uF-11@gated-at.bofh.it> <rt1vR-2uF-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> index 79defba..97a1f5f 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -167,12 +167,21 @@ blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter, loff_t offset)
> struct file *file = iocb->ki_filp;
> struct inode *inode = bdev_file_inode(file);
>
> - if (IS_DAX(inode))
> + if (iocb_is_direct(iocb))
> + return __blockdev_direct_IO(iocb, inode, I_BDEV(inode), iter,
> + offset, blkdev_get_block, NULL,
> + NULL, DIO_SKIP_DIO_COUNT);
> + else if (iocb_is_dax(iocb))
> return dax_do_io(iocb, inode, iter, offset, blkdev_get_block,
> NULL, DIO_SKIP_DIO_COUNT);
> - return __blockdev_direct_IO(iocb, inode, I_BDEV(inode), iter, offset,
> - blkdev_get_block, NULL, NULL,
> - DIO_SKIP_DIO_COUNT);
> + else {
> + /*
> + * If we're in the direct_IO path, either the IOCB_DIRECT or
> + * IOCB_DAX flags must be set.
> + */
> + WARN_ONCE(1, "Kernel Bug with iocb flags\n");
> + return -ENXIO;
> + }
DAX should not even end up in ->direct_IO.
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -300,7 +300,7 @@ xfs_file_read_iter(
>
> XFS_STATS_INC(mp, xs_read_calls);
>
> - if (unlikely(iocb->ki_flags & IOCB_DIRECT))
> + if (unlikely(iocb->ki_flags & (IOCB_DIRECT | IOCB_DAX)))
> ioflags |= XFS_IO_ISDIRECT;
please also add a XFS_IO_ISDAX flag to propagate the information
properly and allow tracing to display the actual I/O type.
> +static inline bool iocb_is_dax(struct kiocb *iocb)
> {
> + return IS_DAX(file_inode(iocb->ki_filp)) &&
> + (iocb->ki_flags & IOCB_DAX);
> +}
> +
> +static inline bool iocb_is_direct(struct kiocb *iocb)
> +{
> + return iocb->ki_flags & IOCB_DIRECT;
> }
No need for these helpers - especially as IOCB_DAX should never be set
if IS_DAX is false.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Vishal Verma <vishal.l.verma@intel.com> - 2016-04-28 23:20 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Christoph Hellwig <hch@infradead.org> - 2016-05-02 17:00 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Vishal Verma <vishal@kernel.org> - 2016-05-02 17:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 17:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Vishal Verma <vishal@kernel.org> - 2016-05-02 18:00 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 18:10 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-02 21:00 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-02 18:10 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 18:30 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-02 19:00 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 19:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-02 20:20 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 20:40 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-02 20:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 21:30 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Christoph Hellwig <hch@infradead.org> - 2016-05-05 16:30 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-05 17:20 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Christoph Hellwig <hch@infradead.org> - 2016-05-05 17:30 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io Dan Williams <dan.j.williams@intel.com> - 2016-05-05 18:30 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-05 23:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "hch@infradead.org" <hch@infradead.org> - 2016-05-08 11:10 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-08 20:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-05 23:50 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "Verma, Vishal L" <vishal.l.verma@intel.com> - 2016-05-05 23:40 +0200
Re: [PATCH v4 5/7] fs: prioritize and separate direct_io from dax_io "hch@infradead.org" <hch@infradead.org> - 2016-05-08 11:10 +0200
csiph-web