Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management

From	Manish Badarkhe <badarkhe.manish@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management
Date	2016-05-04 05:30 +0200
Message-ID	<ruVFE-42F-5@gated-at.bofh.it> (permalink)
References	<ruzlL-ir-3@gated-at.bofh.it> <ruzlM-ir-9@gated-at.bofh.it> <ruzOO-PC-17@gated-at.bofh.it> <ruGdz-6GP-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark

>> > +static const unsigned int wm831x_usb_limits[] = {
>> > +       0,
>> > +       2,
>> > +       100,
>> > +       500,
>> > +       900,
>> > +       1500,
>> > +       1800,
>> > +       550,
>> > +};
>
>> Just for curiosity, How these current limits are getting decided?
>> Can we have some proper defines over here so that it can be grasped easily?
>
> They're in the silicon, it's just a table of values that were put into
> the silicon at design time.  The defines would just be TABLE_ENTRY_1 or
> whatever.

Thanks for the clarification, In that case, comments/documentation
will work instead of making any defines.

Regards
Manish Badarkhe

Thread

[RESEND PATCH v10 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-05-03 05:40 +0200
  [RESEND PATCH v10 3/4] gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang <baolin.wang@linaro.org> - 2016-05-03 05:40 +0200
  [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang <baolin.wang@linaro.org> - 2016-05-03 05:40 +0200
    Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger  current limit management Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-05-03 06:10 +0200
      Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger  current limit management Mark Brown <broonie@kernel.org> - 2016-05-03 13:00 +0200
        Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger  current limit management Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-05-04 05:30 +0200
          Re: [RESEND PATCH v10 4/4] power: wm831x_power: Support USB charger  current limit management Mark Brown <broonie@kernel.org> - 2016-05-04 11:00 +0200
  [RESEND PATCH v10 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-05-03 05:40 +0200

csiph-web