Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391277

Re: klp: make object/func-walking helpers more robust

Show all headers | View raw

+++ Miroslav Benes [28/04/16 16:34 +0200]:
>Current object-walking helper checks the presence of obj->funcs to
>determine the end of objs array in klp_object structure. This is
>somewhat fragile because one can easily forget about funcs definition
>during livepatch creation. In such a case the livepatch module is
>successfully loaded and all objects after the incorrect one are omitted.
>This is very confusing. Let's make the helper more robust and check also
>for the other external member, name. Thus the helper correctly stops on
>an empty item of the array. We need to have a check for obj->funcs in
>klp_init_object() to make it work.
>
>The same applies to a func-walking helper.
>
>As a benefit we'll check for new_func member definition during the
>livepatch initialization. There is no such check anywhere in the code
>now.
>
>Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Acked-by: Jessica Yu <jeyu@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] klp: make object/func-walking helpers more robust Miroslav Benes <mbenes@suse.cz> - 2016-04-28 16:40 +0200
  Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-28 20:30 +0200
    Re: klp: make object/func-walking helpers more robust Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-28 23:20 +0200
      Re: klp: make object/func-walking helpers more robust Miroslav Benes <mbenes@suse.cz> - 2016-04-29 09:50 +0200
        Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-29 18:20 +0200
    Re: klp: make object/func-walking helpers more robust Jiri Kosina <jikos@kernel.org> - 2016-04-29 10:40 +0200
  Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-29 18:30 +0200
  Re: [PATCH] klp: make object/func-walking helpers more robust Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-29 18:30 +0200
  Re: [PATCH] klp: make object/func-walking helpers more robust Jiri Kosina <jikos@kernel.org> - 2016-04-30 00:10 +0200

csiph-web