Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391220

[PATCH 02/13] bpf tools: Fix syscall argument

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>

Coverity flagged this under CID 1354884 as a sizeof mismatch, it turns
out that the argument "attr" passed to syscall should have been a
pointer to attr in the first place.

Reported-by: coverity (CID 1354884)
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 8f9e05fb298f ("perf tools: Fix PowerPC native building")
Link: http://lkml.kernel.org/r/1461551694-5512-3-git-send-email-f.fainelli@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/feature/test-bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
index 8236df9a46ca..e04ab89a1013 100644
--- a/tools/build/feature/test-bpf.c
+++ b/tools/build/feature/test-bpf.c
@@ -31,5 +31,5 @@ int main(void)
 	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
 	 * This call should fail if we run the testcase.
 	 */
-	return syscall(__NR_bpf, BPF_PROG_LOAD, attr, sizeof(attr));
+	return syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
 }
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 09/13] perf record: Force enable --timestamp-filename when --switch-output is provided Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 11/13] perf record: Generate tracking events for process forked by perf Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 10/13] perf record: Disable buildid cache options by default in switch output mode Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 02/13] bpf tools: Fix syscall argument Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 13/13] perf tests: Do not use sizeof on pointer type Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 12/13] perf trace: Move msg_flags beautifier to tools/perf/trace/beauty/ Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:00 +0200
  [PATCH 01/13] bpf tools: Remove expression with no effect Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  [PATCH 08/13] perf record: Split output into multiple files via '--switch-output' Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  [PATCH 05/13] perf probe: Use strbuf for making strings Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  [PATCH 03/13] perf evsel: Handle ENOMEM for perf_event_max_stack + PERF_SAMPLE_CALLCHAIN Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  [PATCH 04/13] perf evsel: Remove two extraneous ending newlines in open_strerror() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  [PATCH 06/13] perf tools: Introduce trigger class Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-29 17:10 +0200
  Re: [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2016-04-29 21:40 +0200

csiph-web