Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc

From	Daniel Stone <daniel@fooishbar.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc
Date	2016-04-27 10:30 +0200
Message-ID	<rst18-6uo-11@gated-at.bofh.it> (permalink)
References	<rrXkB-57R-3@gated-at.bofh.it> <rrXkC-57R-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 26 April 2016 at 00:33, Gustavo Padovan <gustavo@padovan.org> wrote:
> +static inline struct drm_crtc *fence_to_crtc(struct fence *fence)
> +{
> +       if (fence->ops != &drm_crtc_fence_ops)
> +               return NULL;

Since this is (currently) only used before unconditional dereferences,
maybe turn this into a BUG_ON instead of return NULL?

Cheers,
Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Gustavo Padovan <gustavo@padovan.org> - 2016-04-26 00:40 +0200
  Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 12:20 +0200
    Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-04-26 16:30 +0200
      Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 18:40 +0200
  Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Daniel Stone <daniel@fooishbar.org> - 2016-04-27 10:30 +0200

csiph-web