Re: [PATCH 3/3] lightnvm: rename dma helper functions

From	Javier González <javigon.napster@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] lightnvm: rename dma helper functions
Date	2016-04-27 22:20 +0200
Message-ID	<rsE6e-7r0-5@gated-at.bofh.it> (permalink)
References	<rsBrI-4Yl-3@gated-at.bofh.it> <rsBrI-4Yl-15@gated-at.bofh.it> <rsCQO-66m-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>      if (dev->ops->max_phys_sect > 1) {
>> -        dev->ppalist_pool = dev->ops->create_dma_pool(dev, "ppalist");
>> -        if (!dev->ppalist_pool) {
>> +        dev->dma_page_pool = dev->ops->create_dma_pool(dev, "ppalist");
> 
> rename to dmapool or something similar?
> 
>> +        if (!dev->dma_page_pool) {
>>              pr_err("nvm: could not create ppa pool\n");
> 
> Make sure to fix up the text here as well. Else it looks good.
> 
>>              ret = -ENOMEM;
> 

Thanks. I'll fix it and resubmit tomorrow. 

Javier.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] lightnvm: rename dma helper functions "Javier González" <jg@lightnvm.io> - 2016-04-27 19:30 +0200
  Re: [PATCH 3/3] lightnvm: rename dma helper functions Matias Bjørling <m@bjorling.me> - 2016-04-27 21:00 +0200
    Re: [PATCH 3/3] lightnvm: rename dma helper functions Javier González <javigon.napster@gmail.com> - 2016-04-27 22:20 +0200

csiph-web