Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule
Date	2016-04-27 20:20 +0200
Message-ID	<rsCe6-5LS-13@gated-at.bofh.it> (permalink)
References	<rsldj-8vJ-67@gated-at.bofh.it> <rsBrI-4Yl-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2016-04-27 at 19:27 +0200, Sebastian Ott wrote:
> On Wed, 27 Apr 2016, Ben Hutchings wrote:
> > 
> > 3.16.35-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > 
> > commit 80c544ded25ac14d7cc3e555abb8ed2c2da99b84 upstream.
> > 
> > The function measurement block must not cross a page boundary. Ensure
> > that by raising the alignment requirement to the smallest power of 2
> > larger than the size of the fmb.
> > 
> > Fixes: d0b088531 ("s390/pci: performance statistics and debug infrastructure")
> > Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > [bwh: Backported to 3.16: adjust context]
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> The BUILD_BUG_ON below will be triggered. This patch has a
> dependency on commit:
> 	6001018ae "s390/pci: extract software counters from fmb"
> could you please fetch that one too?
[...]

Thanks, I've now done that.  I'm hoping to get cross-architecture build
testing for 3.16.y in place soon so I can catch this sort of thing
earlier.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule Ben Hutchings <ben@decadent.org.uk> - 2016-04-27 02:10 +0200
  Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule Sebastian Ott <sebott@linux.vnet.ibm.com> - 2016-04-27 19:30 +0200
    Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule Ben Hutchings <ben@decadent.org.uk> - 2016-04-27 20:20 +0200

csiph-web