Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1387075

Re: [patch] skd: remove broken discard support

Show all headers | View raw

> On Apr 25, 2016, at 4:06 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
> 
> Simply creating a file system on an skd device, followed by mount and
> fstrim will result in errors in the logs and then a BUG().  Let's remove
> discard support from that driver.  As far as I can tell, it hasn't
> worked right since it was merged.  This patch also has a side-effect of
> cleaning up an unintentional shadowed declaration inside of
> skd_end_request.
> 
> I tested to ensure that I can still do I/O to the device using xfstests
> ./check -g quick.  I didn't do anything more extensive than that,
> though.

Applied, thanks Jeff. 

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch] skd: remove broken discard support Jeff Moyer <jmoyer@redhat.com> - 2016-04-26 00:10 +0200
  Re: [patch] skd: remove broken discard support Jens Axboe <axboe@kernel.dk> - 2016-04-26 04:00 +0200

csiph-web