Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386251

Re: [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

Show all headers | View raw

On 04/21/2016 02:25 PM, Laxman Dewangan wrote:
> Use devm_mfd_add_devices() for adding MFD child devices and
> devm_regmap_add_irq_chip() for IRQ chip registration.
> 
> This reduces the error code path and .remove callback for removing
> MFD child devices and deleting IRQ chip data.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> CC: Chanwoo Choi <cw00.choi@samsung.com>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/mfd/max77686.c | 31 ++++++++-----------------------
>  1 file changed, 8 insertions(+), 23 deletions(-)

Switching existing code to devm-like interface doesn't bring huge
benefits but looks okay and I'm fine with it:

Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 14:40 +0200
  [PATCH 1/7] mfd: as3722: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 14:40 +0200
    Re: [PATCH 1/7] mfd: as3722: Use devm_mfd_add_devices and  devm_regmap_add_irq_chip Lee Jones <lee.jones@linaro.org> - 2016-04-28 11:10 +0200
  [PATCH 4/7] mfd: rc5t583: Use devm_mfd_add_devices and devm_request_threaded_irq Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 14:40 +0200
    Re: [PATCH 4/7] mfd: rc5t583: Use devm_mfd_add_devices and  devm_request_threaded_irq Lee Jones <lee.jones@linaro.org> - 2016-04-28 11:10 +0200
  [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 14:40 +0200
    Re: [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and  devm_regmap_add_irq_chip Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-25 13:00 +0200
      Re: [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and  devm_regmap_add_irq_chip Lee Jones <lee.jones@linaro.org> - 2016-04-28 11:10 +0200
        Re: [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-28 12:20 +0200
  [PATCH 5/7] mfd: sec: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-21 14:40 +0200
    Re: [PATCH 5/7] mfd: sec: Use devm_mfd_add_devices and  devm_regmap_add_irq_chip Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-25 14:50 +0200
  Re: [PATCH 0/7] mfd: Use devm_mfd_add_devices and  devm_regmap_add_irq_chip Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-25 13:00 +0200
    Re: [PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-25 15:10 +0200

csiph-web