Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl

From	Sowmini Varadhan <sowmini.varadhan@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl
Date	2016-04-21 19:50 +0200
Message-ID	<rqqTN-4ry-9@gated-at.bofh.it> (permalink)
References	<rqkEG-8dU-3@gated-at.bofh.it> <rqqAr-4fG-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (04/21/16 10:23), Tadeusz Struk wrote:
> 
> What if the mpi_limb_t will happen to be 64 bit? 
> Thanks,

When I checked this with cscope, I found

typedef unsigned long int mpi_limb_t;

thus I used the *32 functions. 

But you obviously know better, since you wrote this code (and bug).
If you anticipate that mpi_limb_t in some environment today,
I can check for sizeof(mpi_limb_t), and predicate it to
use the *32 or *64 functions based on the result. Do you think that
is necessary?

Regards,
--Sowmini

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2016-04-21 13:10 +0200
  Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl Tadeusz Struk <tadeusz.struk@intel.com> - 2016-04-21 19:30 +0200
    Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2016-04-21 19:50 +0200

csiph-web