Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1384269
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler |
| Date | 2016-04-21 16:10 +0200 |
| Message-ID | <rqnsR-1UE-1@gated-at.bofh.it> (permalink) |
| References | <rpumK-5J-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Apr 18, 2016 at 08:11:50PM -0700, Alexei Starovoitov wrote: > move trace_call_bpf() into helper function to minimize the size > of perf_trace_*() tracepoint handlers. > text data bss dec hex filename > 10541679 5526646 2945024 19013349 1221ee5 vmlinux_before > 10509422 5526646 2945024 18981092 121a0e4 vmlinux_after > > It may seem that perf_fetch_caller_regs() can also be moved, > but that is incorrect, since ip/sp will be wrong. > > bpf+tracepoint performance is not affected, since > perf_swevent_put_recursion_context() is now inlined. > export_symbol_gpl can also be dropped. > > No measurable change in normal perf tracepoints. > > Suggested-by: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Alexei Starovoitov <ast@kernel.org> > --- > include/linux/trace_events.h | 5 +++++ > include/trace/perf.h | 13 +++---------- > kernel/events/core.c | 20 +++++++++++++++++++- > 3 files changed, 27 insertions(+), 11 deletions(-) > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> David, please take through the net tree as this depends on prior patches by Alexei that are already in your tree.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler Alexei Starovoitov <ast@fb.com> - 2016-04-19 05:20 +0200
Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler Peter Zijlstra <peterz@infradead.org> - 2016-04-21 16:10 +0200
Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler Steven Rostedt <rostedt@goodmis.org> - 2016-04-21 16:20 +0200
Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler David Miller <davem@davemloft.net> - 2016-04-21 20:00 +0200
csiph-web