Re: [PATCH mmotm 1/5] huge tmpfs: try to allocate huge pages split into a team fix

From	Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH mmotm 1/5] huge tmpfs: try to allocate huge pages split into a team fix
Date	2016-04-21 01:50 +0200
Message-ID	<rqa2C-7RY-1@gated-at.bofh.it> (permalink)
References	<roHP4-30O-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Hugh,

On Sat, 16 Apr 2016 16:27:02 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
>
> Please replace the
> huge-tmpfs-try-to-allocate-huge-pages-split-into-a-team-fix.patch
> you added to your tree by this one: nothing wrong with Stephen's,
> but in this case I think the source is better off if we simply
> remove that BUILD_BUG() instead of adding an IS_ENABLED():
> fixes build problem seen on arm when putting together linux-next.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>  mm/shmem.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -1744,7 +1744,6 @@ static inline struct page *shmem_hugetea
>  
>  static inline void shmem_disband_hugeteam(struct page *page)
>  {
> -	BUILD_BUG();
>  }
>  
>  static inline void shmem_added_to_hugeteam(struct page *page,

I have replaced my fix with the above in today's linux-next.

-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH mmotm 1/5] huge tmpfs: try to allocate huge pages split into  a team fix Hugh Dickins <hughd@google.com> - 2016-04-17 01:30 +0200
  [PATCH mmotm 2/5] huge tmpfs: fix mlocked meminfo track huge unhuge  mlocks fix Hugh Dickins <hughd@google.com> - 2016-04-17 01:40 +0200
    Re: [PATCH mmotm 2/5] huge tmpfs: fix mlocked meminfo track huge  unhuge mlocks fix Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-21 01:50 +0200
  [PATCH mmotm 4/5] huge tmpfs: avoid premature exposure of new  pagetable revert Hugh Dickins <hughd@google.com> - 2016-04-17 01:40 +0200
    Re: [PATCH mmotm 4/5] huge tmpfs: avoid premature exposure of new  pagetable revert Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-21 02:00 +0200
  [PATCH mmotm 3/5] huge tmpfs recovery: tweak shmem_getpage_gfp to  fill team fix Hugh Dickins <hughd@google.com> - 2016-04-17 01:40 +0200
    Re: [PATCH mmotm 3/5] huge tmpfs recovery: tweak shmem_getpage_gfp  to fill team fix Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-21 02:00 +0200
  [PATCH mmotm 5/5] huge tmpfs: add shmem_pmd_fault() Hugh Dickins <hughd@google.com> - 2016-04-17 01:50 +0200
    Re: [PATCH mmotm 5/5] huge tmpfs: add shmem_pmd_fault() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-04-17 02:50 +0200
      Re: [PATCH mmotm 5/5] huge tmpfs: add shmem_pmd_fault() Hugh Dickins <hughd@google.com> - 2016-04-17 03:30 +0200
    Re: [PATCH mmotm 5/5] huge tmpfs: add shmem_pmd_fault() Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-21 02:00 +0200
  Re: [PATCH mmotm 1/5] huge tmpfs: try to allocate huge pages split  into a team fix Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-21 01:50 +0200

csiph-web