Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385203

Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 22, 2016 at 02:33:02PM +0100, Richard Fitzgerald wrote:
> This patch adds a debugfs file for the always_on flag in struct regulator.
> It's useful for debugging to be able to view the state of this flag and
> as it's set by logic inside the regulator core it doesn't necessarily have
> the same value as the always_on flag in constraints.

Why not include this in the same file as the rest of the constraints?
Or why not have one file per constraint (which would be easier for
scripts)?

> +	ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);

> +		debugfs_create_file("always_on", 0444, regulator->debugfs,

It seems to be formatted as though it's going to end up in the same file
but it's a separate file so instead it's just repeating the name of the
file inside the file.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] regulator: core: Add debugfs for regulator always_on flag Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-04-22 15:40 +0200
  Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag Mark Brown <broonie@kernel.org> - 2016-04-22 16:00 +0200
    Re: [PATCH] regulator: core: Add debugfs for regulator always_on  flag Richard Fitzgerald <rf@opensource.wolfsonmicro.com> - 2016-04-22 16:50 +0200

csiph-web