Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384990

Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or

Show all headers | View raw

On Fri, Apr 22, 2016 at 11:04 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> All the atomic operations have their arguments the wrong way around;

s/wrong/other/?

> make atomic_fetch_or() consistent and flip them.

BTW, there are a few other inconsistencies:

atomic_add_unless()
atomic_cmpxchg()
atomic_inc_not_zero_hint()
atomic_set()
atomic_xchg

git grep "\<atomic_.*atomic_t\>.*\<int\>"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or Peter Zijlstra <peterz@infradead.org> - 2016-04-22 12:00 +0200
  Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or Will Deacon <will.deacon@arm.com> - 2016-04-22 13:00 +0200
  Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-22 13:10 +0200
    Re: [RFC][PATCH 01/31] locking: Flip arguments to atomic_fetch_or Peter Zijlstra <peterz@infradead.org> - 2016-04-22 16:30 +0200

csiph-web