Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1384961

Re: [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Apr 21, 2016 at 05:12:00PM +0100, Jon Hunter wrote:

> A regulator that is in bypass will fail to be registered because we will
> attempt to get the voltage of the regulator (ie. it's bypass voltage)
> before the supply for the regulator has been resolved. Therefore, when
> getting the voltage for a bypassed regulator, if the supply has not been
> resolved, then attempt to resolve it. Additionally, move the setup of
> the regulator's supply name to before the call to
> set_machine_constraints() so that it can be resolved.

The basic pattern here makes sense but rather than doing this
specifically in the case where we have a bypassed supply we didn't 
resolve yet I think we should instead always try to resolve the supply
but ignore the error unless we actively need the supply.  I'd be
surprised if we didn't run into other cases where we need to do this so
it seems better to try the resolution in one place.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] regulator: A few fixes for supply resolution Jon Hunter <jonathanh@nvidia.com> - 2016-04-21 18:20 +0200
  [PATCH 1/5] regulator: core: Don't terminate supply resolution early Jon Hunter <jonathanh@nvidia.com> - 2016-04-21 18:20 +0200
    Applied "regulator: core: Don't terminate supply resolution early" to the regulator tree Mark Brown <broonie@kernel.org> - 2016-04-22 13:00 +0200
  [PATCH 4/5] regulator: core: Add early supply resolution for a bypassed regulator Jon Hunter <jonathanh@nvidia.com> - 2016-04-21 18:20 +0200
    Re: [PATCH 4/5] regulator: core: Add early supply resolution for a  bypassed regulator Mark Brown <broonie@kernel.org> - 2016-04-22 12:50 +0200
      Re: [PATCH 4/5] regulator: core: Add early supply resolution for a  bypassed regulator Jon Hunter <jonathanh@nvidia.com> - 2016-04-22 13:30 +0200
        Re: [PATCH 4/5] regulator: core: Add early supply resolution for a  bypassed regulator Mark Brown <broonie@kernel.org> - 2016-04-22 16:00 +0200
          Re: [PATCH 4/5] regulator: core: Add early supply resolution for a  bypassed regulator Jon Hunter <jonathanh@nvidia.com> - 2016-04-25 16:50 +0200
            Re: [PATCH 4/5] regulator: core: Add early supply resolution for a  bypassed regulator Mark Brown <broonie@kernel.org> - 2016-04-25 19:00 +0200

csiph-web