Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd ... && pwd)

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd ... && pwd)
Date	2016-04-18 17:40 +0200
Message-ID	<rpjrl-7Ud-33@gated-at.bofh.it> (permalink)
References	<rlAK6-1xG-25@gated-at.bofh.it> <rpiEW-7e9-31@gated-at.bofh.it> <rpiYj-7Ft-25@gated-at.bofh.it> <rpj7Z-7JL-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 04:17:26PM +0100, Maciej W. Rozycki wrote:
> On Mon, 18 Apr 2016, Thierry Reding wrote:
> 
> > > > Avoid forking off a shell to resolve the absolute path of the output
> > > > directory when make's builtin $(abspath ...) function will do an
> > > > adequate job.
> > > 
> > > The abspath function is not available in make 3.80.
> > 
> > Do we really support make 3.80? It was released in 2002 and 3.81
> > followed in April 2006. That makes it a decade old now. I'd be surprised
> > if anyone was still using it to build recent kernels.
> > 
> > Is there a formal process for increasing the dependencies listed in
> > Documentation/Changes? Should I simply make that change as part of this
> > patch? Do we need broad approval?
> 
>  Hmm, what problem are you trying to solve here?  Your proposal looks to 
> me like a gratuitous requirement for users to upgrade their tool (its age 
> doesn't matter), which is often a burden and in any case requires extra 
> time which could be used for something else.  Don't fix what ain't broke!

Fine.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd  ... && pwd) Michal Marek <mmarek@suse.com> - 2016-04-18 16:50 +0200
  Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd  ... && pwd) Thierry Reding <thierry.reding@gmail.com> - 2016-04-18 17:10 +0200
    Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd  ... && pwd) "Maciej W. Rozycki" <macro@linux-mips.org> - 2016-04-18 17:20 +0200
      Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd  ... && pwd) Thierry Reding <thierry.reding@gmail.com> - 2016-04-18 17:40 +0200

csiph-web