Re: [PATCH v2 13/13] MIPS: mm: Panic if an XPA kernel is run without RIXI

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 13/13] MIPS: mm: Panic if an XPA kernel is run without RIXI
Date	2016-04-18 12:10 +0200
Message-ID	<rpehY-3HT-33@gated-at.bofh.it> (permalink)
References	<rpdOV-3aq-9@gated-at.bofh.it> <rpdOV-3aq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 10:35:33AM +0100, Paul Burton wrote:
> XPA kernels hardcode for the presence of RIXI - the PTE format & its
> handling presume RI & XI bits. Make this dependence explicit by panicing
> if we run on a system that violates it.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> 
> ---
> 
> Changes in v2:
> - New patch, in response to clarification on patch 5.
> 
>  arch/mips/mm/tlbex.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 3f1a8a2..9c39c66 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -2395,6 +2395,9 @@ void build_tlb_refill_handler(void)
>  	 */
>  	static int run_once = 0;
>  
> +	if (config_enabled(CONFIG_XPA) && !cpu_has_rixi)
> +		panic("Kernels supporting XPA currently require CPUs with RIXI\n");

Don't think you need the newline.

Otherwise
Reviewed-by: James Hogan <james.hogan@imgtec.com>

In the future we can hopefully drop that requirement so that XPA kernels
can run on non-XPA, non-RIXI hardware.

Cheers
James

> +
>  	output_pgtable_bits_defines();
>  	check_pabits();
>  
> -- 
> 2.8.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 13/13] MIPS: mm: Panic if an XPA kernel is run without RIXI Paul Burton <paul.burton@imgtec.com> - 2016-04-18 11:40 +0200
  Re: [PATCH v2 13/13] MIPS: mm: Panic if an XPA kernel is run without  RIXI James Hogan <james.hogan@imgtec.com> - 2016-04-18 12:10 +0200

csiph-web