Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380396
| From | Giedrius Statkevičius <giedrius.statkevicius@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set |
| Date | 2016-04-16 02:10 +0200 |
| Message-ID | <rolYe-347-25@gated-at.bofh.it> (permalink) |
| References | <rolYe-347-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Properly return rv back to the caller in the case of an error in
parse_arg. In the process remove a unused variable 'out'.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
drivers/platform/x86/asus-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index d86d42e..9a69734 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
const char *method)
{
int rv, value;
- int out = 0;
rv = parse_arg(buf, count, &value);
- if (rv > 0)
- out = value ? 1 : 0;
+ if (rv <= 0)
+ return rv;
if (write_acpi_int(asus->handle, method, value))
return -ENODEV;
--
2.8.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius <giedrius.statkevicius@gmail.com> - 2016-04-16 02:10 +0200
[PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius <giedrius.statkevicius@gmail.com> - 2016-04-16 02:10 +0200
Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Darren Hart <dvhart@infradead.org> - 2016-04-20 22:30 +0200
Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius <giedrius.statkevicius@gmail.com> - 2016-04-21 08:40 +0200
Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-21 22:40 +0200
Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Darren Hart <dvhart@infradead.org> - 2016-04-21 23:00 +0200
Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Darren Hart <dvhart@infradead.org> - 2016-04-25 19:50 +0200
Re: [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-22 01:10 +0200
csiph-web