Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379980
| From | David Lechner <david@lechnology.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb |
| Date | 2016-04-15 18:20 +0200 |
| Message-ID | <roeDo-5Pa-43@gated-at.bofh.it> (permalink) |
| References | <rnUlk-6mH-3@gated-at.bofh.it> <rnUll-6mH-23@gated-at.bofh.it> <ro9DI-1Ev-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 04/15/2016 05:48 AM, Sergei Shtylyov wrote:
> On 4/14/2016 9:35 PM, David Lechner wrote:
>
>> Device tree binding for new phy-da8xx-usb driver.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>
>> v4 changes:
>>
>> * swapped order of usb20 and usb11 to be in logical order of reg address.
>>
>> .../devicetree/bindings/phy/phy-da8xx-usb.txt | 40
>> ++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>> b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>> new file mode 100644
>> index 0000000..bead185
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
>> @@ -0,0 +1,40 @@
>> +TI DaVinci DA8xx USB PHY
>
> DA8xx is not DaVinci, please omit this.
Just to be sure, you mean omit "DaVinci"?
>
>> +
>> +Required properties:
>> + - compatible: must be "ti,da830-usbphy".
>> + - #phy-cells: must be 1.
>> +
>> +This device controls the PHY for both the USB 1.1 OHCI and USB 2.0 OTG
>> +controllers on DA8xx SoCs. Consumers of this device should use index
>> 0 for
>> +the USB 2.0 phy device and index 1 for the USB 1.1 phy device.
>
> Not indices 2 and 1 already?
I changed this to reflect the TRM. USB0PHY = USB 2.0 and USB1PHY = USB 1.1
>
>> + usbphy: usbphy {
>
> Name it "usb-phy" please, consistent to what ePAPR has mandated for
> Ethernet PHYs.
Ack.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/7] da8xx USB PHY (was da8xx USB clocks) David Lechner <david@lechnology.com> - 2016-04-14 20:40 +0200
[PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb David Lechner <david@lechnology.com> - 2016-04-14 20:40 +0200
Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-15 13:00 +0200
Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb David Lechner <david@lechnology.com> - 2016-04-15 18:20 +0200
Re: [PATCH v4 2/7] dt-bindings: Add bindings for phy-da8xx-usb Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-04-15 19:10 +0200
[PATCH v4 6/7] usb: musb: da8xx: Use devm in probe David Lechner <david@lechnology.com> - 2016-04-14 20:40 +0200
csiph-web