Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377677
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable |
| Date | 2016-04-13 11:20 +0200 |
| Message-ID | <rnp7Q-7vE-5@gated-at.bofh.it> (permalink) |
| References | <rljSW-5SJ-5@gated-at.bofh.it> <rljSW-5SJ-15@gated-at.bofh.it> <rnoYa-7qk-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed 13-04-16 11:08:30, Ingo Molnar wrote:
>
> * Michal Hocko <mhocko@kernel.org> wrote:
[...]
> > +ENTRY(call_rwsem_down_write_failed_killable)
> > + save_common_regs
> > + movq %rax,%rdi
> > + call rwsem_down_write_failed_killable
> > + restore_common_regs
> > + ret
> > +ENDPROC(call_rwsem_down_write_failed_killable)
>
> Got this objtool warning on x86-64 allyesconfig:
>
> arch/x86/lib/rwsem.o: warning: objtool: call_rwsem_down_write_failed_killable()+0xe: call without frame pointer save/setup
Peter has already pointed that out. This is because the 4.5 which I was
basing my work on doesn't have 3387a535ce62 ("x86/asm: Create stack
frames in rwsem functions") which shown up in 4.6-rc1. He mentioned to
add the missing FRAME_{BEGIN,END} during the merge AFAIR.
Does that sound reasonable to you or should I rebase?
--
Michal Hocko
SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 10/11] x86, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-07 17:20 +0200
Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Ingo Molnar <mingo@kernel.org> - 2016-04-13 11:10 +0200
Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-13 11:20 +0200
Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Ingo Molnar <mingo@kernel.org> - 2016-04-13 11:30 +0200
Re: [PATCH 10/11] x86, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-04-13 15:00 +0200
[PATCH] x86: add frame annotation for call_rwsem_down_write_failed_killable Michal Hocko <mhocko@kernel.org> - 2016-04-13 12:00 +0200
csiph-web