Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1377047
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: checkpatch false positon on EXPORT_SYMBOL |
| Date | 2016-04-12 19:50 +0200 |
| Message-ID | <rnaBQ-2QL-9@gated-at.bofh.it> (permalink) |
| References | <riMoq-6WJ-5@gated-at.bofh.it> <riQs2-1gf-13@gated-at.bofh.it> <rmS2e-4ac-21@gated-at.bofh.it> <rmSlA-4EU-15@gated-at.bofh.it> <rn65d-7BQ-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> On Tue, 2016-04-12 at 13:59 +0100, Andy Whitcroft wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3000,7 +3000,7 @@ sub process {
>
> $realline_next = $line_nr_next;
> if (defined $realline_next &&
> (!defined $lines[$realline_next - 1] ||
> - substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
> + substr($lines[$realline_next - 1], $off_next) =~ /^($;|\s)*$/)) {
> $realline_next++;
> }
This doesn't work with c99 comments like:
int foo; // comment
EXPORT_SYMBOL(foo); // comment
but then again, there aren't any uses like that in the
kernel tree so it almost certainly doesn't matter.
Thanks Andy.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: checkpatch false positon on EXPORT_SYMBOL Daniel Walker <danielwa@cisco.com> - 2016-04-12 00:00 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Joe Perches <joe@perches.com> - 2016-04-12 00:20 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Andy Whitcroft <apw@canonical.com> - 2016-04-12 15:00 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Daniel Walker <danielwa@cisco.com> - 2016-04-12 15:40 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Joe Perches <joe@perches.com> - 2016-04-12 19:50 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Daniel Walker <danielwa@cisco.com> - 2016-04-12 20:10 +0200
Re: checkpatch false positon on EXPORT_SYMBOL Andy Whitcroft <apw@canonical.com> - 2016-04-13 09:00 +0200
csiph-web