Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379002

Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage
Date 2016-04-14 17:20 +0200
Message-ID <rnRdM-3Ro-41@gated-at.bofh.it> (permalink)
References <rnwVJ-4Qk-19@gated-at.bofh.it> <rnx5n-4TK-9@gated-at.bofh.it> <rnJge-5Y0-11@gated-at.bofh.it> <rnOIX-1Cp-43@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote:

> I totally agree that there is an abstraction failure here in both sides. It
> should be fixed. moving to using bulk apis would solve the nvmem problem for
> now. But for long term, using regmap should be totally removed from nvmem
> and directly use the reg read/write callbacks from nvmem providers, This
> would be much robust solution. This was indeed Maxime's first proposal. I
> will try to fix it up and see how it looks without regmap.

OK, so just replacing all the _raw_ calls with _bulk_ for now?  If
you're doing that watch out for the fact that the reads come back native
endian which might upset things.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] nvmem: core: fix regmap accessor usage. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-13 19:40 +0200
  [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-13 19:50 +0200
    Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Mark Brown <broonie@kernel.org> - 2016-04-14 08:50 +0200
      Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-14 14:40 +0200
        Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Mark Brown <broonie@kernel.org> - 2016-04-14 17:20 +0200
          Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-14 18:50 +0200
  [PATCH v1 1/3] regmap: add regmap_can_raw_read() api Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-13 19:50 +0200
    Re: [PATCH v1 1/3] regmap: add regmap_can_raw_read() api Mark Brown <broonie@kernel.org> - 2016-04-14 08:00 +0200

csiph-web