Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379043
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V1] regulator: pv88080: new regulator driver |
| Date | 2016-04-14 17:50 +0200 |
| Message-ID | <rnRGO-44y-21@gated-at.bofh.it> (permalink) |
| References | <rnKlY-6Jd-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Apr 14, 2016 at 04:32:04PM +0900, James Bans wrote:
A couple of minor points but otherwise this looks good:
> +static const int pv88080_buck2_limits[] = {
> + 1496000, 2393000, 3291000, 4189000
> +};
> +
> +static const int pv88080_buck3_limits[] = {
> + 1496000, 2393000, 3291000, 4189000
> +};
These two appear identical so should just be one array.
> + switch (data & PV88080_BUCK1_MODE_MASK) {
> + case PV88080_BUCK_MODE_SYNC:
> + mode = REGULATOR_MODE_FAST;
> + break;
> + case PV88080_BUCK_MODE_AUTO:
> + mode = REGULATOR_MODE_NORMAL;
> + break;
> + case PV88080_BUCK_MODE_SLEEP:
> + mode = REGULATOR_MODE_STANDBY;
> + break;
> + }
I know mode was initialized above but this would be clearer with a
default: case.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH V1] regulator: pv88080: new regulator driver James Bans <James.Ban.opensource@diasemi.com> - 2016-04-14 10:00 +0200 Re: [PATCH V1] regulator: pv88080: new regulator driver Mark Brown <broonie@kernel.org> - 2016-04-14 17:50 +0200
csiph-web