Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1378810
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/4] i2c: designware-pcidrv: enable RuntimePM before registering to the core |
| Date | 2016-04-14 15:00 +0200 |
| Message-ID | <rnP2j-1K8-11@gated-at.bofh.it> (permalink) |
| References | <rnP2i-1K8-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
As pointed out by commit 36d48fb5766a ("i2c: designware-platdrv: enable
RuntimePM before registering to the core"), "The core may register
clients attached to this master which may use funtionality from the
master", so enable RuntimePM before registering to the core.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 7368be0..41a01a7 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -248,14 +248,17 @@ static int i2c_dw_pci_probe(struct pci_dev *pdev,
ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
adap->nr = controller->bus_num;
+ pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
+ pm_runtime_use_autosuspend(&pdev->dev);
+ pm_runtime_allow(&pdev->dev);
+
r = i2c_dw_probe(dev);
- if (r)
+ if (r) {
+ pm_runtime_forbid(&pdev->dev);
return r;
+ }
- pm_runtime_set_autosuspend_delay(&pdev->dev, 1000);
- pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_put_autosuspend(&pdev->dev);
- pm_runtime_allow(&pdev->dev);
return 0;
}
--
2.8.0.rc3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] i2c: designware: runtime pm fix and improve Jisheng Zhang <jszhang@marvell.com> - 2016-04-14 15:00 +0200 [PATCH 3/4] i2c: designware-pcidrv: enable RuntimePM before registering to the core Jisheng Zhang <jszhang@marvell.com> - 2016-04-14 15:00 +0200 [PATCH 4/4] i2c: designware: remove runtime suspend prevention during registration Jisheng Zhang <jszhang@marvell.com> - 2016-04-14 15:00 +0200
csiph-web