Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization
Date	2016-04-14 11:30 +0200
Message-ID	<rnLL4-7V2-9@gated-at.bofh.it> (permalink)
References	<rnnpo-5TB-25@gated-at.bofh.it> <rnwCm-4E2-9@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Wed, Apr 13, 2016 at 11:11:27AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 13, 2016 at 10:22:06AM +0300, Jarkko Sakkinen wrote:
> > rmmod crashes the driver because tpm_chip_unregister() already sets ops
> > to NULL. This commit fixes the issue by moving tpm2_shutdown() to
> > tpm_chip_unregister(). This commit is also cleanup because it removes
> > duplicate code from tpm_crb and tpm_tis to the core.
> > 
> > v2: make sending shutdown command atomic with nulling ops
> > v3: forgot to amend updates, sorry :(
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Fixes: 4d3eac5e156a ("tpm: Provide strong locking for device
> > removal")
> 
> You patch got a little mangled.. The v2/v3 should be after the
> diffstat, not in the commit message and the --- after the SOB section
> is missing..
> 
> Otherwise it looks fine
> 
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Thanks I'll apply this. 

/Jarkko

> >  extern int tpm2_startup(struct tpm_chip *chip, u16 startup_type);
> > -extern void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type);
> > +void tpm2_shutdown(struct tpm_chip *chip, u16 shutdown_type);
> 
> Drop this hunk though, doesn't do anything.
> 
> If you don't like the unnecessary externs on functions then get rid of
> them all in a patch.

[x]

> Jason

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] tpm: fix crash in tpm_tis deinitialization Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-13 09:30 +0200
  Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-04-13 19:20 +0200
    Re: [PATCH v3] tpm: fix crash in tpm_tis deinitialization Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-14 11:30 +0200

csiph-web