Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support
Date	2016-04-14 08:10 +0200
Message-ID	<rnIDx-5In-21@gated-at.bofh.it> (permalink)
References	<rfp4Z-1bB-5@gated-at.bofh.it> <rkorE-3JL-9@gated-at.bofh.it> <rkFsu-X4-11@gated-at.bofh.it> <rnqdA-8e7-9@gated-at.bofh.it> <rntO9-2uP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 13, 2016 at 7:11 AM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Apr 13, 2016 at 3:19 AM, Ingo Molnar <mingo@kernel.org> wrote:
>>
>> * Kees Cook <keescook@chromium.org> wrote:
>>
>>> FWIW, I've also had this tree up in my git branches, and the 0day
>>> tester hasn't complained at all about it in the last two weeks. I'd
>>> really like to see this in -next to fix the >4G (mainly kexec) issues
>>> and get us to feature parity with the arm64 kASLR work (randomized
>>> virtual address).

So, I've done this and suddenly realized I hadn't boot-tested i386. It
doesn't work, unfortunately. (Which I find strange: I'd expect 0day to
have noticed...)

Baoquan, have you tested this on 32-bit systems? I get a variety of
failures. Either it boots okay, it reboots, or I get tons of pte
errors like this:

[    0.000000] clearing pte for ram above max_low_pfn: pfn: 37dcc pmd:
f9144f7c pmd phys: 39144f7c pte: f9a1b730 pte phys: 39a1b730

Can you confirm? I suspect relocation problems, but ran out of time
today to debug it.

I have the entire series with cleaned up changelogs and various other
refactorings up here now:

http://git.kernel.org/cgit/linux/kernel/git/kees/linux.git/log/?h=kaslr/highmem

Thanks!

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

Thread

Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Baoquan He <bhe@redhat.com> - 2016-04-05 04:00 +0200
  Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Kees Cook <keescook@chromium.org> - 2016-04-05 22:10 +0200
    Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Ingo Molnar <mingo@kernel.org> - 2016-04-13 12:30 +0200
      Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Kees Cook <keescook@chromium.org> - 2016-04-13 16:20 +0200
        Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Kees Cook <keescook@chromium.org> - 2016-04-14 08:10 +0200
          Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Baoquan He <bhe@redhat.com> - 2016-04-14 08:30 +0200
          Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Baoquan He <bhe@redhat.com> - 2016-04-14 17:10 +0200
            Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Kees Cook <keescook@chromium.org> - 2016-04-14 20:00 +0200
              Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Baoquan He <bhe@redhat.com> - 2016-04-15 06:10 +0200
                Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Kees Cook <keescook@chromium.org> - 2016-04-15 07:00 +0200
                Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Ingo Molnar <mingo@kernel.org> - 2016-04-15 09:00 +0200

csiph-web