Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created

From	Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created
Date	2016-04-11 03:10 +0200
Message-ID	<rmywx-5QK-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <rlzO2-Ty-21@gated-at.bofh.it> <rlzXI-XP-19@gated-at.bofh.it> <rlAqK-1ai-17@gated-at.bofh.it> <rlBZw-2oe-17@gated-at.bofh.it> <rlC9c-2s3-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016/4/8 18:46, Marc Zyngier wrote:
> On 08/04/16 11:33, Kefeng Wang wrote:
>>
>>
>> On 2016/4/8 16:53, Marc Zyngier wrote:
>>> On Fri, 8 Apr 2016 16:26:21 +0800
>>> Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
[...]
>> But there is still one issue in the for_each_child_of_node loop of
>> mbigen_device_probe. Assume that there are 3+ child node(mbigen_gmac,
>> mbigen_i2c, mbigen_xxx, etc) in mbigen_chip_dsa, if one of them with
>> incorrect configuration, then the loop will end, but we still need 
>> parse the left child node. we should consider this situation, right?
> 
> That's up to whoever designed the driver to decide, really. I don't know
> if it is worth continuing in that case (and you are in a better position
> than me to find out).

Ok, will talk with Ma Jun directly, and if the change is needed, I will send
a new patch after reviewed by Ma Jun.

Thanks,
Kefeng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip/mbigen: Display message of MBIGEN domain created Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-08 09:30 +0200
  Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain  created Marc Zyngier <marc.zyngier@arm.com> - 2016-04-08 10:20 +0200
    Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-08 10:30 +0200
      Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain  created Marc Zyngier <marc.zyngier@arm.com> - 2016-04-08 11:00 +0200
        Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-08 12:40 +0200
          Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Marc Zyngier <marc.zyngier@arm.com> - 2016-04-08 12:50 +0200
            Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-11 03:10 +0200

csiph-web