Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1376360

Re: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, 2016-04-10 at 11:33 -0700, Greg Kroah-Hartman wrote:
> 4.5-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Raghava Aditya Renukunta <raghavaaditya.renukunta@pmcs.com>
> 
> commit ecc479e00db8eb110b200afe1effcb3df20ca7ae upstream.
> 
> During EEH recovery number of online CPU's might change thereby changing
> the number of MSIx vectors. Since each fib is allocated to a vector,
> changes in the number of vectors causes fib to be sent thru invalid
> vectors.In addition the correct number of MSIx vectors is not updated in
> the INIT struct sent to the controller, when it is reinitialized.
> 
> Fixed by reassigning vectors to fibs based on the updated number of MSIx
> vectors and updating the INIT structure before sending to controller.

Really?

[...]
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -1404,8 +1404,18 @@ static int aac_acquire_resources(struct
>  
>  	aac_adapter_enable_int(dev);
>  
> -	if (!dev->sync_mode)
> +	/*max msix may change  after EEH
> +	 * Re-assign vectors to fibs
> +	 */
> +	aac_fib_vector_assign(dev);
> +
> +	if (!dev->sync_mode) {
> +		/* After EEH recovery or suspend resume, max_msix count
> +		 * may change, therfore updating in init as well.
> +		 */
>  		aac_adapter_start(dev);
> +		dev->init->Sa_MSIXVectors = cpu_to_le32(dev->max_msix);

Aren't these two lines in the wrong order?

Ben.

> +	}
>  	return 0;
>  
>  error_iounmap:
-- 
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-10 22:50 +0200
  Re: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH  recovery Ben Hutchings <ben@decadent.org.uk> - 2016-04-12 02:30 +0200
    RE: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH  recovery Raghava Aditya Renukunta <RaghavaAditya.Renukunta@pmcs.com> - 2016-04-12 20:10 +0200

csiph-web