Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1373424
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/5] regulator: helpers: Ensure bypass register field matches ON value |
| Date | 2016-04-07 16:30 +0200 |
| Message-ID | <rlj6y-5b8-7@gated-at.bofh.it> (permalink) |
| References | <rlj6y-5b8-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Jon Hunter <jonathanh@nvidia.com> When checking the bypass state for a regulator, we check to see if any bits in the bypass mask are set. For most cases this is fine because there is typically only a single bit used to determine if the regulator is in bypass. However, for some regulators, such as LDO6 on AS3722, the bypass state is indicated by a value rather than a single bit. Therefore, when checking the bypass state, check that the bypass field matches the ON value. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/regulator/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index b1e32e7482e9..bcf38fd5106a 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -460,7 +460,7 @@ int regulator_get_bypass_regmap(struct regulator_dev *rdev, bool *enable) if (ret != 0) return ret; - *enable = val & rdev->desc->bypass_mask; + *enable = (val & rdev->desc->bypass_mask) == rdev->desc->bypass_val_on; return 0; } -- 2.8.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 3/5] regulator: helpers: Ensure bypass register field matches ON value Thierry Reding <thierry.reding@gmail.com> - 2016-04-07 16:30 +0200
csiph-web