Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1373280

Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode

Show all headers | View raw

在 2016/4/6 21:01, Andy Shevchenko 写道:
> On Wed, Apr 6, 2016 at 10:07 AM, qiujiang <qiujiang@huawei.com> wrote:
>> This patch converts device node to fwnode for dwapb driver, so
>> as to provide a unified fwnode for DT and ACPI bindings.
>>
>> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Signed-off-by: qiujiang <qiujiang@huawei.com>
> 
>>  static struct dwapb_platform_data *
>> -dwapb_gpio_get_pdata_of(struct device *dev)
>> +dwapb_gpio_get_pdata(struct device *dev)
> 
> I don't remember if I had asked already
> does it fit now one row?
Hi Andy,

It dose not fit one row yet, checkpatch.pl will report a warning.
> 
>> @@ -495,9 +493,10 @@ dwapb_gpio_get_pdata_of(struct device *dev)
>>                  * Only port A can provide interrupts in all configurations of
>>                  * the IP.
>>                  */
>> -               if (pp->idx == 0 &&
>> -                   of_property_read_bool(port_np, "interrupt-controller")) {
>> -                       pp->irq = irq_of_parse_and_map(port_np, 0);
>> +               if (dev->of_node && pp->idx == 0 &&
> 
> is_of_fwnode() && ?
> 
>> +                       fwnode_property_read_bool(fwnode,
>> +                                                 "interrupt-controller")) {
>> +                       pp->irq = irq_of_parse_and_map(to_of_node(fwnode), 0);
>>                         if (!pp->irq)
>>                                 dev_warn(dev, "no irq for this bank\n");
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang <qiujiang@huawei.com> - 2016-04-06 09:00 +0200
  Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-06 15:10 +0200
    Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode Jiang Qiu <qiujiang@huawei.com> - 2016-04-07 13:20 +0200
  Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-04-15 04:40 +0200

csiph-web