Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1374180

Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms after reset"

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 08, 2016 at 10:10:06AM +0100, Nick Dyer wrote:
> On 2016-04-07 23:52, Tom Rini wrote:
> > This reverts commit 885f3fb9fa1f9e185e8a4e905157087495734349 due to this
> > change breaking the touchpad on the Chromebook Pixel 2015 on resume from
> > sleep or warm resets.
> > 
> > Cc: Olof Johansson <olof@lixom.net>
> > Cc: Nick Dyer <nick.dyer@itdev.co.uk>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Henrik Rydberg <rydberg@bitmath.org>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> 
> Hi Tom-
> 
> Sorry that this has caused a problem. I suggest we try and find a 3rd
> option other than reverting this patch, because otherwise we will cause
> problems on other platforms.

Yeah, it would be good to fix all platforms.  I'm curious, was there an
observed problem on another platform or just a theoretical problem?

> I have a Pixel 2 here - can you advise how to reproduce?

I (and a bunch of other folks, the linux-samus people now point people
at using mxt-app every boot to reset the device) see this every time I
either suspend the laptop or do a warm boot into a new kernel (I didn't
try kexec but it too is probably broken).  Note that I'm not using
mainline to boot ChromeOS but I've got a regular Linux distro in ROOT-C.

-- 
Tom

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms after reset" Tom Rini <trini@konsulko.com> - 2016-04-08 01:00 +0200
  Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Nick Dyer <nick.dyer@itdev.co.uk> - 2016-04-08 11:20 +0200
    Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Tom Rini <trini@konsulko.com> - 2016-04-08 14:20 +0200
      Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Nick Dyer <nick.dyer@itdev.co.uk> - 2016-04-08 14:30 +0200
        Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Tom Rini <trini@konsulko.com> - 2016-04-08 14:40 +0200
          Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Nick Dyer <nick.dyer@itdev.co.uk> - 2016-04-08 23:40 +0200
            Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms  after reset" Tom Rini <trini@konsulko.com> - 2016-04-09 01:30 +0200
              [PATCH] Input: atmel_mxt_ts - use mxt_acquire_irq in mxt_soft_reset Nick Dyer <nick.dyer@itdev.co.uk> - 2016-04-11 11:40 +0200

csiph-web