Re: [PATCH] tpm: remove redundant code from self-test functions

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: remove redundant code from self-test functions
Date	2016-04-05 11:50 +0200
Message-ID	<rkvMu-13F-9@gated-at.bofh.it> (permalink)
References	<riom6-60u-3@gated-at.bofh.it> <riDEu-cW-3@gated-at.bofh.it> <riEqT-P8-29@gated-at.bofh.it> <rjkgp-5Ym-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Apr 01, 2016 at 09:16:15PM -0600, Jason Gunthorpe wrote:
> On Thu, Mar 31, 2016 at 09:37:56AM +0300, Jarkko Sakkinen wrote:
> > On Wed, Mar 30, 2016 at 11:46:23PM -0600, Jason Gunthorpe wrote:
> > > On Wed, Mar 30, 2016 at 04:20:45PM +0300, Jarkko Sakkinen wrote:
> > >   
> > > > -		rc = be32_to_cpu(cmd.header.out.return_code);
> > > >  		if (rc == TPM_ERR_DISABLED || rc == TPM_ERR_DEACTIVATED) {
> > > 
> > > This line is the entire reason it is open coded, I see it being
> > > removed, but I don't see how the functionality is maintained?
> > 
> > When tpm_trance_cmd() returns a positive number it is the TPM error code
> > that it returns. tpm_pcr_read() does pass through whatever
> > tpm_trace_cmd() returns so the above condition should still work as
> > expected.
> 
> Okay, everything looks fine to me

I applied this to http://git.infradead.org/users/jjs/linux-tpmdd.git in
order to get exposure (tested-by's are always welcome).

> Jason

/Jarkko

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-05 11:50 +0200
  Re: [PATCH] tpm: remove redundant code from self-test functions Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-07 13:40 +0200

csiph-web