Re: [RFC PATCH 3/4] pinctrl: Add ACPI support

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/4] pinctrl: Add ACPI support
Date	2016-04-05 09:50 +0200
Message-ID	<rktUm-8dF-31@gated-at.bofh.it> (permalink)
References	<riJgR-4jD-3@gated-at.bofh.it> <riJgS-4jD-19@gated-at.bofh.it> <rkcTv-3Fi-1@gated-at.bofh.it> <rkdmy-47v-21@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, Apr 04, 2016 at 02:01:13PM +0000, Tirdea, Irina wrote:
> > > +  {
> > > +      ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > +          Package()
> > > +          {
> > > +              Package (2) {"pins", Package () {pin1, pin2, ...}},
> > > +              Package (2) {configname1, configval1},
> > 
> > These should be enclosed in quotes, like "configname1" and so on.
> > 
> OK. Should all string properties be enclosed in quotes or only the property names
> (e.g. should I also change values like "configval1", "pin1", "statename1", etc.)?

I think all types should be documented using correct format. Strings
should have "" and so on.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 3/4] pinctrl: Add ACPI support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-04 15:40 +0200
  RE: [RFC PATCH 3/4] pinctrl: Add ACPI support "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-04-04 16:10 +0200
    Re: [RFC PATCH 3/4] pinctrl: Add ACPI support Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-05 09:50 +0200

csiph-web