Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1372211

[PATCH] regulator: twl: Fix a typo in twl4030_send_pb_msg

From Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] regulator: twl: Fix a typo in twl4030_send_pb_msg
Date 2016-04-06 08:10 +0200
Message-ID <rkOP7-84y-9@gated-at.bofh.it> (permalink)
References <rkHDY-2qu-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Commit <2330b05c095bdeaaf1261c54cd2d4b9127496996> ("regulator: twl: Make
sure we have access to powerbus before trying to write to it")
has implemented the needed logic to correctly access powerbus through i2c,
however it brought a typo when powerbus configuration is restored, which
results in writing to a wrong register. Fix that by providing the correct
register value.

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
 drivers/regulator/twl-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 11c6a5c..faeb5ee 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -253,7 +253,7 @@ static int twl4030_send_pb_msg(unsigned msg)
 
 	/* Restore powerbus configuration */
 	return twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
-				TWL_MODULE_PM_MASTER);
+				TWL4030_PM_MASTER_PB_CFG);
 }
 
 static int twl4030reg_enable(struct regulator_dev *rdev)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/3] regulator: twl: Make sure we have access to powerbus  before trying to write to it Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-04-06 00:30 +0200
  [PATCH] regulator: twl: Fix a typo in twl4030_send_pb_msg Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-04-06 08:10 +0200

csiph-web