Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized
Date	2016-04-03 18:40 +0200
Message-ID	<rjTea-6bQ-7@gated-at.bofh.it> (permalink)
References	<ri6pb-1Bd-9@gated-at.bofh.it> <riNDR-7LE-43@gated-at.bofh.it> <rj2jw-1v4-11@gated-at.bofh.it> <rj7VT-5vb-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 1, 2016 at 4:02 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Apr 01, 2016 at 10:04:57AM +0200, Linus Walleij wrote:

>> > Please ignore/drop this patch - a better (cleaner) fix is in the works
>> > for gpiolib.
>>
>> This delivers though. I tested it on my also regressing iPAQ.
>>
> I am a bit concerned that the gpio initialization was that early on purpose,
> and that by moving it we might miss some use cases. I did not find any, but that
> doesn't mean that there are none. Without knowing _why_ the initialization was
> that early, I would prefer not to touch the code if it can be avoided.

I think we'll go for the other patch to gpiolib. It seems much more clean
and generic to support this kind of cases.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has been initialized Guenter Roeck <linux@roeck-us.net> - 2016-03-29 20:20 +0200
  Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has  been initialized Guenter Roeck <linux@roeck-us.net> - 2016-03-31 18:30 +0200
    Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has  been initialized Linus Walleij <linus.walleij@linaro.org> - 2016-04-01 10:10 +0200
      Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has  been initialized Guenter Roeck <linux@roeck-us.net> - 2016-04-01 16:10 +0200
        Re: [PATCH] ARM: sa1100: Initialize gpio after gpio subsystem has  been initialized Linus Walleij <linus.walleij@linaro.org> - 2016-04-03 18:40 +0200

csiph-web