Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1369348

Re: [PATCH] s390: fix build failure

From Heiko Carstens <heiko.carstens@de.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] s390: fix build failure
Date 2016-04-01 16:10 +0200
Message-ID <rj7VU-5vb-33@gated-at.bofh.it> (permalink)
References <rj6wN-4fI-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Apr 01, 2016 at 01:35:16PM +0100, Sudip Mukherjee wrote:
> s390 defconfig and allmodconfig fails with the error:
> kernel/seccomp.c: In function '__secure_computing_strict':
> kernel/seccomp.c:526:3: error: implicit declaration of function
> 				'get_compat_mode1_syscalls'
> 
> The retrieval of compat syscall numbers were moved into inline function
> defined in asm-generic header but the asm-generic header was not being
> used by s390.
> 
> Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header")
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> 
> Tested with s390 defconfig and allmodconfig build.
> Build logs of next-20160401 are at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983952 (allmodconfig)
> and
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/119983909 (defconfig)
> 
>  arch/s390/include/asm/seccomp.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/s390/include/asm/seccomp.h b/arch/s390/include/asm/seccomp.h
> index 781a9cf..e10f833 100644
> --- a/arch/s390/include/asm/seccomp.h
> +++ b/arch/s390/include/asm/seccomp.h
> @@ -13,4 +13,6 @@
>  #define __NR_seccomp_exit_32	__NR_exit
>  #define __NR_seccomp_sigreturn_32 __NR_sigreturn
> 
> +#include <asm-generic/seccomp.h>
> +
>  #endif	/* _ASM_S390_SECCOMP_H */

Applied with a modified changelog, since it makes sense anyway to include
the generic header file.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] s390: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-01 14:40 +0200
  Re: [PATCH] s390: fix build failure Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-04-01 16:10 +0200

csiph-web