Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1367284

Re: [RFC v1] sched/completion: convert completions to use simple wait queues

Show all headers | View raw

On Wed, Mar 30, 2016 at 04:53:05PM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> 
> Completions have no long lasting callbacks and therefore do not need
> the complex waitqueue variant.  Use simple waitqueues which reduces
> the contention on the waitqueue lock.

Changelog really should have talk about the determinism thing. The last
time you posted this the point was raised that we should wake the
highest prio waiter in the defer case, you did not address this.

Also, you make no mention of the reduction of UINT_MAX to USHORT_MAX and
the implications of that.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v1] sched/completion: convert completions to use simple wait queues Daniel Wagner <wagi@monom.org> - 2016-03-30 17:00 +0200
  Re: [RFC v1] sched/completion: convert completions to use simple  wait queues Peter Zijlstra <peterz@infradead.org> - 2016-03-30 17:10 +0200
    Re: [RFC v1] sched/completion: convert completions to use simple wait  queues Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-03-30 17:20 +0200
      Re: [RFC v1] sched/completion: convert completions to use simple wait  queues Daniel Wagner <wagi@monom.org> - 2016-03-30 17:30 +0200
      Re: [RFC v1] sched/completion: convert completions to use simple  wait queues Peter Zijlstra <peterz@infradead.org> - 2016-03-30 17:30 +0200

csiph-web