Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

From	Kalle Valo <kvalo@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif
Date	2016-03-30 07:20 +0200
Message-ID	<rigHU-Er-5@gated-at.bofh.it> (permalink)
References	<rhV0J-1YW-1@gated-at.bofh.it> <ri5js-TR-13@gated-at.bofh.it> <ri9wJ-3Fl-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Bjorn Andersson <bjorn.andersson@linaro.org> writes:

>> All error/warnings (new ones prefixed by >>):
>> 
>>    drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key':
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit declaration of function 'wcn36xx_sta_to_priv' [-Werror=implicit-function-declaration]
>>      struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>>             ^
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:33: warning: initialization makes pointer from integer without a cast
>>      struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>>                                     ^
>>    cc1: some warnings being treated as errors
>
> This should have been reordered with patch 7, that introduces this
> helper function. Do you want me to resend, or can you apply the patches
> out of order?

It's better that you resend the whole patchset as v2.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-03-29 08:10 +0200
  Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry  instead of from vif Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-03-29 23:40 +0200
    Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif Kalle Valo <kvalo@codeaurora.org> - 2016-03-30 07:20 +0200

csiph-web