Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1368380
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child |
| Date | 2016-03-31 17:10 +0200 |
| Message-ID | <riMoq-6WJ-9@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <riocq-5Wf-9@gated-at.bofh.it> <rioP8-6bC-19@gated-at.bofh.it> <rioP8-6bC-17@gated-at.bofh.it> <riFmV-1xL-7@gated-at.bofh.it> <riFPZ-20X-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/31/2016 11:04 AM, Felipe Balbi wrote:
> "Thang Q. Nguyen" <tqnguyen@apm.com> writes:
>> [ text/plain ]
>> Thanks Grygorii for information.
>> I checked but do not see dma_init_dev_from_parent is used in
>> linux-next repository. Can you give me more information for what
>> branch I can checkout to use it for USB DWC3?
>
> dma_init_dev_from_parent() is still a proposal ;-)
>
Felipe,
After some experiments I came up with below fix (not common, but fixes USB
case on keystone 2). if you agree with proposed fix I'll send proper
patches to fix usb_add_gadget_udc_release() and dwc3_host_init() in the same
way.
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index c679f63..3fe1c65 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -17,6 +17,7 @@
#include <linux/platform_device.h>
#include <linux/usb/xhci_pdriver.h>
+#include <linux/of_device.h>
#include "core.h"
@@ -35,8 +36,6 @@ int dwc3_host_init(struct dwc3 *dwc)
dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
xhci->dev.parent = dwc->dev;
- xhci->dev.dma_mask = dwc->dev->dma_mask;
- xhci->dev.dma_parms = dwc->dev->dma_parms;
dwc->xhci = xhci;
@@ -62,6 +61,12 @@ int dwc3_host_init(struct dwc3 *dwc)
phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy",
dev_name(&xhci->dev));
+ if (!dwc->dev->of_node) {
+ xhci->dev.dma_mask = dwc->dev->dma_mask;
+ xhci->dev.dma_parms = dwc->dev->dma_parms;
+ } else
+ of_dma_configure(&xhci->dev, dwc->dev->of_node);
+
ret = platform_device_add(xhci);
if (ret) {
dev_err(dwc->dev, "failed to register xHCI device\n");
--
regards,
-grygorii
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-03-30 15:20 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-03-30 16:00 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child "Thang Q. Nguyen" <tqnguyen@apm.com> - 2016-03-31 09:40 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-03-31 10:10 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Grygorii Strashko <grygorii.strashko@ti.com> - 2016-03-31 17:10 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-01 10:10 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-01 11:50 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-01 12:30 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-01 13:10 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-01 14:00 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child santosh shilimkar <santosh.shilimkar@oracle.com> - 2016-04-01 20:20 +0200
Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Grygorii Strashko <grygorii.strashko@ti.com> - 2016-03-30 16:00 +0200
csiph-web