Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation
Date	2016-03-31 08:30 +0200
Message-ID	<riEhd-JS-21@gated-at.bofh.it> (permalink)
References	(7 earlier) <rijZa-2KA-37@gated-at.bofh.it> <rikLx-3iV-17@gated-at.bofh.it> <rim0W-44B-19@gated-at.bofh.it> <rimtY-4Cw-23@gated-at.bofh.it> <riDuN-92-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Baolin Wang <baolin.wang@linaro.org> writes:
> [ text/plain ]
> On 30 March 2016 at 19:24, Felipe Balbi <balbi@kernel.org> wrote:
>>>> >> >> >
>>>> >> >> > Seems you don't want to guarantee charger type detection is done
>>>> >> >> > before gadget connection(pullup DP), right?
>>>> >> >> > I see you call usb_charger_detect_type() in each gadget usb
>>>> >> >> > state
>>>> >> >> changes.
>>>> >> >>
>>>> >> >> I am not sure I get your point correctly, please correct me if I
>>>> >> >> misunderstand you.
>>>> >> >> We need to check the charger type at every event comes from the
>>>> >> >> usb gadget state changes or the extcon device state changes, which
>>>> >> >> means a new charger plugin or pullup.
>>>> >> >>
>>>> >> >
>>>> >> > According to usb charger spec, my understanding is you can't do
>>>> >> > real charger detection procedure *after* gadget _connection_(pullup
>>>> >> > DP), also I don't
>>>> >>
>>>> >> Why can not? Charger detection is usually from PMIC.
>>>> >
>>>> > Charger detection process will impact DP/DM line state, see usb
>>>> > charger spec v1.2 for detail detection process, section 4.6.3 says:
>>>> >
>>>> > "A PD is allowed to *disconnect* and repeat the charger detection
>>>> > process multiple times while attached. The PD is required to wait for
>>>> > a time of at least TCP_VDM_EN max between disconnecting and restarting
>>>> > the charger detection process."
>>>> >
>>>> > As Peter mentioned, the charger detection should happen between VBUS
>>>> > detection and gadget pull up DP for first plug in case. So when&after
>>>> > gadget connect (pullup DP), you should already know the charger type.
>>>>
>>>> Make sense. In our company's solution, charger detection can be done by
>>>> hardware from PMIC at first, then it will not affect the DP/DM line when
>>>> gadget starts to enumeration.
>>>
>>> I see, charger type detection is done automatically by PMIC when VBUS
>>> is detected in your case, you just assume the process is complete
>>
>> assuming this finishes before gadget starts is a bad idea. It would've
>> been much more robust to delay usb_gadget_connect() until we KNOW
>> charger detection has completed.
>
> It is hardware action to detect the charger type quickly. It actually
> *gets* the charger type and does not means *detect* charger type in
> 'usb_charger_detect_type()' function. Maybe I need to change the
> function name as 'usb_charger_get_type()'.

yes.

> If some udc drivers want to detect charger type in
> 'gadget->ops->get_charger_type()' callback, they should avoid
> impacting DP/DM line state at the right gadget state. Thanks.

they shouldn't detect is get_type(), the semantics doesn't work. If, at
some point, we have to do SW detection of the charger, then a new
->charger_detect() method will have to be added.

-- 
balbi

Thread

[PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-24 13:40 +0100
  [PATCH v8 2/4] gadget: Support for the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-24 13:40 +0100
  [PATCH v8 1/4] gadget: Introduce the usb charger framework Baolin Wang <baolin.wang@linaro.org> - 2016-03-24 13:40 +0100
  [PATCH v8 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang <baolin.wang@linaro.org> - 2016-03-24 13:40 +0100
    Re: [PATCH v8 4/4] power: wm831x_power: Support USB charger current  limit management Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-27 10:30 +0200
      Re: [PATCH v8 4/4] power: wm831x_power: Support USB charger current  limit management Baolin Wang <baolin.wang@linaro.org> - 2016-03-28 08:50 +0200
  [PATCH v8 3/4] gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang <baolin.wang@linaro.org> - 2016-03-24 13:40 +0100
  Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <hzpeterchen@gmail.com> - 2016-03-25 08:20 +0100
    Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-28 09:00 +0200
      Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <hzpeterchen@gmail.com> - 2016-03-28 09:20 +0200
        Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-28 11:20 +0200
          RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <peter.chen@nxp.com> - 2016-03-29 02:50 +0200
            Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-29 04:10 +0200
              Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Mark Brown <broonie@kernel.org> - 2016-03-29 19:20 +0200
        Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Mark Brown <broonie@kernel.org> - 2016-03-29 19:30 +0200
          Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <hzpeterchen@gmail.com> - 2016-03-30 04:10 +0200
            Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-30 09:10 +0200
              Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <hzpeterchen@gmail.com> - 2016-03-30 09:50 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-30 10:50 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Peter Chen <hzpeterchen@gmail.com> - 2016-03-30 11:30 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-30 11:40 +0200
      RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Jun Li <jun.li@nxp.com> - 2016-03-29 11:20 +0200
        Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-29 11:50 +0200
          RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Jun Li <jun.li@nxp.com> - 2016-03-30 05:00 +0200
            Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-30 08:20 +0200
              RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Jun Li <jun.li@nxp.com> - 2016-03-30 10:50 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-30 11:40 +0200
                RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Jun Li <jun.li@nxp.com> - 2016-03-30 13:00 +0200
                RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi <balbi@kernel.org> - 2016-03-30 13:30 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 07:40 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi <balbi@kernel.org> - 2016-03-31 08:30 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 08:40 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 07:30 +0200
                RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Jun Li <jun.li@nxp.com> - 2016-03-31 08:20 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 08:40 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Felipe Balbi <balbi@kernel.org> - 2016-03-31 10:20 +0200
                Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the  usb gadget power negotation Baolin Wang <baolin.wang@linaro.org> - 2016-03-31 10:30 +0200

csiph-web