Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT
Date	2016-03-31 08:30 +0200
Message-ID	<riEhc-JS-13@gated-at.bofh.it> (permalink)
References	<ri7Oi-2sv-9@gated-at.bofh.it> <ri7Oi-2sv-11@gated-at.bofh.it> <riDXQ-Ch-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 31, 2016 at 3:09 PM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> On Wed, Mar 30, 2016 at 4:41 AM, Mark Brown <broonie@kernel.org> wrote:
>> Since we changed to do formatting in the bus we now skip all the format
>> parsing that the core does for its data marshalling code.  This means
>> that we skip the DT parsing it does which breaks some systems, we need
>> to add an explict call in the MMIO code to do this.
>>
>> Reported-by: Alexander Stein <alexander.stein@systec-electronic.com>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> This breaks my syscon reboot handler (Exynos4412, Trats2):
> ###############
> -sh-4.1# reboot
> Rebooting.
> [   37.056210] reboot: Restarting system
> [   38.058649] Unable to restart system
> [   39.060987] Reboot failed -- System halted
> ###############
>
> I added a printk before switch and:
> config->val_format_endian: REGMAP_ENDIAN_DEFAULT
> regmap_get_val_endian(): REGMAP_ENDIAN_BIG,
>

... and the big-endian is coming from the last return in
regmap_get_val_endian() (/* Use this if no other value was found */).
I don't have endian property in DTS for the syscon device so it always
ended with default which in the regmap_mmio_gen_context() was mapped
to little endian. Now default is big endian.

I guess the big/little endian property should be required in that case.

Best regards,
Krzysztof

Thread

[PATCH 2/2] regmap: mmio: Parse endianness definitions from DT Mark Brown <broonie@kernel.org> - 2016-03-29 21:50 +0200
  Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT Alexander Stein <alexander.stein@systec-electronic.com> - 2016-03-30 12:40 +0200
  Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-31 08:10 +0200
    Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-31 08:30 +0200
    Re: [PATCH 2/2] regmap: mmio: Parse endianness definitions from DT Mark Brown <broonie@kernel.org> - 2016-03-31 19:20 +0200

csiph-web