Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier

From	Daniel Wagner <wagi@monom.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier
Date	2016-03-31 07:10 +0200
Message-ID	<riD1L-8oO-1@gated-at.bofh.it> (permalink)
References	<r8GDD-2P0-7@gated-at.bofh.it> <r8GDE-2P0-39@gated-at.bofh.it> <rhYL1-4yM-11@gated-at.bofh.it> <ri3B0-86I-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Namhyung,

On 03/29/2016 05:17 PM, Namhyung Kim wrote:
> On Tue, Mar 29, 2016 at 12:01:40PM +0200, Daniel Wagner wrote:
>> cat /sys/kernel/debug/tracing/events/test/latency_complete/hist
>> # event histogram
>> #
>> # trigger info: hist:keys=latency.log2:vals=hitcount:sort=latency.log2:size=2048 [active]
>> #
>> #
> 
> Maybe we want to skip printing those flags for sort keys..
> What about this?

Yes, something like this makes sense to me. As I said, it is only a
minor detail and maybe just not worth the extra code.

Anyway, the hist patches do really work nicely. I hope they get merged soon.

cheers,
daniel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier Daniel Wagner <wagi@monom.org> - 2016-03-29 12:10 +0200
  Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier Namhyung Kim <namhyung@kernel.org> - 2016-03-29 17:20 +0200
    Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier Daniel Wagner <wagi@monom.org> - 2016-03-31 07:10 +0200

csiph-web