Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1366466

Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node

From Shaohua Li <shli@fb.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node
Date 2016-03-29 18:50 +0200
Message-ID <ri507-wp-23@gated-at.bofh.it> (permalink)
References <rgHCy-7Rl-3@gated-at.bofh.it> <rhWg9-2Ka-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 29, 2016 at 12:24:43AM -0700, Christoph Hellwig wrote:
> On Fri, Mar 25, 2016 at 02:36:30PM -0700, Shaohua Li wrote:
> > we allocate most data structure in device's node, but some data
> > structures are not for DMA and mostly used by specific cpus/node which
> > could diff from device's node. Allocating such hot data in device's
> > node doesn't make sense. Add an API to estimate hardware queue node.
> > This can be used before blk-mq actually establishes the mapping. This
> > API runs slow, but it only used in initialization time.
> 
> I think this is the wrong way around.  I've got some proprotype code
> that just leaves the cpu assignments to the drivers and picks it up
> in blk-mq.  Give me a few days to post it..

This looks weird, shouldn't the cpu assignment be determined by block
core (blk-mq) because block core decides how to use the queue?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] blk-mq: add an API to estimate hardware queue node Shaohua Li <shli@fb.com> - 2016-03-25 22:40 +0100
  Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Christoph Hellwig <hch@infradead.org> - 2016-03-29 09:30 +0200
    Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Shaohua Li <shli@fb.com> - 2016-03-29 18:50 +0200
      Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Jens Axboe <axboe@fb.com> - 2016-03-29 19:00 +0200
        Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Christoph Hellwig <hch@infradead.org> - 2016-03-29 19:50 +0200
          Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Jens Axboe <axboe@fb.com> - 2016-03-29 23:00 +0200
            Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Christoph Hellwig <hch@infradead.org> - 2016-03-29 23:30 +0200
              Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Jens Axboe <axboe@fb.com> - 2016-03-29 23:30 +0200

csiph-web