Re: [PATCH v5 2/6] hwmon: (fam15h_power) Add compute unit accumulated power

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/6] hwmon: (fam15h_power) Add compute unit accumulated power
Date	2016-03-29 10:00 +0200
Message-ID	<rhWJc-2Uj-11@gated-at.bofh.it> (permalink)
References	<rhBbH-4sP-5@gated-at.bofh.it> <rhBOq-50t-15@gated-at.bofh.it> <rhBOq-50t-13@gated-at.bofh.it> <rhWpP-2Nj-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 29, 2016 at 09:31:58AM +0200, Peter Zijlstra wrote:
> This will not in fact work for Intel, nor if I manage to one day
> randomize our CPU numbers on AMD.

Oh, I know why. I have this 64 CPUs box here:

$ grep "core id" /proc/cpuinfo | uniq
core id         : 0
core id         : 8
core id         : 2
core id         : 10
core id         : 1
core id         : 9
core id         : 3
core id         : 11
core id         : 0
core id         : 8
core id         : 2
core id         : 10
core id         : 1
core id         : 9
core id         : 3
core id         : 11

Those core IDs repeat and are almost random too :)

I guess we'll need a mask. Maybe as a future exercise...

That box's topology has other funsies like this:

$ grep -E -B 2 "core id\s+: 0" /proc/cpuinfo
physical id     : 0
siblings        : 16
core id         : 0
--
physical id     : 1
siblings        : 16
core id         : 0
--
physical id     : 2
siblings        : 16
core id         : 0
--
physical id     : 3
siblings        : 16
core id         : 0
--
physical id     : 0
siblings        : 16
core id         : 0
--
physical id     : 1
siblings        : 16
core id         : 0
--
physical id     : 2
siblings        : 16
core id         : 0
--
physical id     : 3
siblings        : 16
core id         : 0

So in order to dig out which HT threads belong together, I need to look
at the (core id, physical id) pair.

I guess this is how we "fix" the schedulers of other OSes - by playing
topology games...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/6] hwmon: (fam15h_power) Add compute unit  accumulated power Borislav Petkov <bp@alien8.de> - 2016-03-28 11:40 +0200
  Re: [PATCH v5 2/6] hwmon: (fam15h_power) Add compute unit  accumulated power Peter Zijlstra <peterz@infradead.org> - 2016-03-29 09:40 +0200
    Re: [PATCH v5 2/6] hwmon: (fam15h_power) Add compute unit  accumulated power Borislav Petkov <bp@alien8.de> - 2016-03-29 10:00 +0200

csiph-web