Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1365539

Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.

Show all headers | View raw

On 03/25/2016 12:22 PM, Sergei Shtylyov wrote:
> On 03/25/2016 02:51 AM, David Lechner wrote:
>> +/* register offsets */
>> +#define CFGCHIP_REG(n)                (n * 4)
>> +#define CFGCHIP0_REG                CFGCHIP_REG(0)
>> +#define CFGCHIP1_REG                CFGCHIP_REG(1)
>> +#define CFGCHIP2_REG                CFGCHIP_REG(2)
>> +#define CFGCHIP3_REG                CFGCHIP_REG(3)
>> +#define CFGCHIP4_REG                CFGCHIP_REG(4)
>
>     Why not just use CFGCHIP_REG(n) directly?

I considered that, but I went this way because A) the TRM uses, for 
example, "CFGCHIP2", so I wanted to keep "CFGCHIP" and "2" together and 
B) this tells you how many CFGCHIP registers there are, i.e. there is no 
CFGCHIP5_REG.

>> @@ -53,7 +31,6 @@ struct    da8xx_ohci_root_hub {
>>       /* Time from power on to power good (in 2 ms units) */
>>       u8    potpgt;
>>   };
>> -
>
>     Why?

Unintentional. Must have sneaked in through rebasing or something.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers. David Lechner <david@lechnology.com> - 2016-03-25 01:00 +0100
  Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP  registers. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-25 18:30 +0100
    Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP  registers. David Lechner <david@lechnology.com> - 2016-03-28 17:10 +0200
      Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP  registers. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-03-28 18:50 +0200

csiph-web