Re: call_usermodehelper in containers

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: call_usermodehelper in containers
Date	2016-03-25 02:40 +0100
Message-ID	<rgoTf-2J7-1@gated-at.bofh.it> (permalink)
References	(4 earlier) <mdmme-2i2-5@gated-at.bofh.it> <mep8m-5Iz-21@gated-at.bofh.it> <meprI-6la-21@gated-at.bofh.it> <mfAO6-53d-23@gated-at.bofh.it> <rg8bN-7NQ-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ian,

I can't really recall this old discussion, so I can be easily wrong...

On 03/24, Ian Kent wrote:
>
> On Mon, 2013-11-18 at 18:28 +0100, Oleg Nesterov wrote:
> >
> > IOW. Please the the "patch" below. It is obviously incomplete and
> > wrong,
> > and it can be more clear/clean. And probably we need another API. Just
> > to explain what I mean.

I hope you didn't miss this part ;)

In particular, we want to turn task_work_add(..., bool notify) into
task_work_add(..., how_to_notify mask) and this "mask" should allow
to force TIF_SIGPENDING.

> > With this patch call_usermodehelper(..., UMH_IN_MY_NS) should do exec
> > from the caller's namespace.
>
> Umm ... I don't think this can work.
>
> I don't think it can be assumed that the init process of a container
> will behave like an init process.
>
> If you try and do this with a Docker container that has /bin/bash as the
> init process signals never arrive and work doesn't start until some
> other signal arrives

only if it blocks/ignores SIGCHLD? But this doesn't matter, see above and
note the "until we have task_work_add_interruptibel()" in the pseudo-code
I showed.

> I probably don't understand what's actually going on, this is just my
> impression of what I'm seeing.

Or perhaps it is me who misunderstands your concerns.

Oleg.

Thread

Re: call_usermodehelper in containers Ian Kent <raven@themaw.net> - 2016-03-24 08:50 +0100
  Re: call_usermodehelper in containers Oleg Nesterov <oleg@redhat.com> - 2016-03-25 02:40 +0100
    Re: call_usermodehelper in containers Ian Kent <raven@themaw.net> - 2016-03-25 08:30 +0100

csiph-web