Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1363386

Re: [PATCH 0/2] Change the the config option of mbigen driver.

Show all headers | View raw

On Wednesday 23 March 2016 17:06:31 MaJun wrote:
> From: Ma Jun <majun258@huawei.com>
> 
> In current driver, the config of mbigen driver is a configurable option and
> have nothing to do with CONFIG_ARCH_HISI.
> 
> As a module of Hisilicon SOC, the config of mbigen driver should be selected
> by CONFIG_ARCH_HISI on Hisilicon platform, but not a configurable option.
> 
> This patch set is applied to fix this problem.
> 
> 

I don't understand this one. I thought mbigen is specific to just one
of Hisilicon's SoC families, while ARCH_HISI is more generic and can
also be set for the other ones.

Maybe just add 'default ARCH_HISI' and 'depends on ARCH_HISI || COMPILE_TEST'
to the option? We should certainly keep building this driver for
compile-test on all architectures.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Change the the config option of mbigen driver. MaJun <majun258@huawei.com> - 2016-03-23 10:10 +0100
  [PATCH 2/2] irqchip/mbigen:Change the config option of mbigen driver to non-configurable MaJun <majun258@huawei.com> - 2016-03-23 10:10 +0100
    [tip:irq/urgent] irqchip/mbigen: Make CONFIG_HISILICON_IRQ_MBIGEN a  hidden option tip-bot for MaJun <tipbot@zytor.com> - 2016-03-23 12:10 +0100
  [PATCH 1/2]ARM64: Enable mbigen interrupt controller on Hisilicon platform MaJun <majun258@huawei.com> - 2016-03-23 10:10 +0100
    [tip:irq/urgent] ARM64: Kconfig: Select mbigen interrupt controller  on Hisilicon platform tip-bot for MaJun <tipbot@zytor.com> - 2016-03-23 12:10 +0100
  Re: [PATCH 0/2] Change the the config option of mbigen driver. Arnd Bergmann <arnd@arndb.de> - 2016-03-23 13:20 +0100

csiph-web