Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe()

From	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe()
Date	2016-03-22 20:50 +0100
Message-ID	<rfAtr-Np-1@gated-at.bofh.it> (permalink)
References	<r0mVr-wW-3@gated-at.bofh.it> <r0mVs-wW-17@gated-at.bofh.it> <rawJR-659-51@gated-at.bofh.it>
Organization	D03

Show all headers | View raw

ping^2

On Tue, Mar 08 2016, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

> ping
>
> On Tue, Feb 09 2016, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
>> We need to use post-decrement to ensure that irq_dispose_mapping is
>> also called on priv->rxq[0]->irq_no; moreover, if one of the above for
>> loops failed already at i==0 (so we reach one of these labels with
>> that value of i), we'll enter an essentially infinite loop of
>> out-of-bounds accesses.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> ---
>>  drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
>> index b02eed12bfc5..73427e29df2a 100644
>> --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
>> +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c
>> @@ -155,11 +155,11 @@ static int sxgbe_platform_probe(struct platform_device *pdev)
>>  	return 0;
>>  
>>  err_rx_irq_unmap:
>> -	while (--i)
>> +	while (i--)
>>  		irq_dispose_mapping(priv->rxq[i]->irq_no);
>>  	i = SXGBE_TX_QUEUES;
>>  err_tx_irq_unmap:
>> -	while (--i)
>> +	while (i--)
>>  		irq_dispose_mapping(priv->txq[i]->irq_no);
>>  	irq_dispose_mapping(priv->irq);
>>  err_drv_remove:

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-03-22 20:50 +0100
  [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-03-26 22:30 +0100
    Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() Francois Romieu <romieu@fr.zoreil.com> - 2016-03-27 10:30 +0200
      Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-03-27 23:50 +0200
      Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() David Miller <davem@davemloft.net> - 2016-03-28 04:50 +0200
    Re: [PATCH] net: sxgbe: fix error paths in sxgbe_platform_probe() David Miller <davem@davemloft.net> - 2016-03-28 04:50 +0200

csiph-web